-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for enableing/disabling cloud ICE servers #22527
base: dev
Are you sure you want to change the base?
Add setting for enableing/disabling cloud ICE servers #22527
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
> | ||
<div class="header-actions"> | ||
<a | ||
href="https://www.nabucasa.com/config/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is yet to change.
"ice_servers": { | ||
"title": "Cloud WebRTC ICE servers", | ||
"info": "Do you want to use Home Assistant Cloud for WebRTC connections? Enable this option to use the Home Assistant Cloud WebRTC ICE servers.", | ||
"link_learn_how_it_works": "Learn how it works" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are yet to change as well.
Core PR is merged. |
Proposed change
This PR adds support for enabling/disabling usage of the cloud ICE servers in the cloud settings page.
The feature itself is implemented in home-assistant/core#128942.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: